hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Liang (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-15458) org.apache.hadoop.fs.TestLocalFileSystem#testFSOutputStreamBuilder fails on Windows
Date Fri, 25 May 2018 00:53:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490061#comment-16490061
] 

Xiao Liang edited comment on HADOOP-15458 at 5/25/18 12:52 AM:
---------------------------------------------------------------

Thanks [~stevel@apache.org] and [~elgoiri] for the suggestion.

The "try(...)" approach works well in my local Windows machine for both trunk([^HADOOP-15458.002.patch])
and branch-2([^HADOOP-15458-branch-2.002.patch]), the test is passed.

Please be noted that I'm using Java 8 in my local Windows machine, the "try-with-resources
Statement" was introduced in Java 7, does it match the Java version for branch-2?


was (Author: surmountian):
Thanks [~stevel@apache.org] and [~elgoiri] for the suggestion.

The "try(...)" approach works well in my local Windows machine for both trunk([^HADOOP-15458.002.patch])
and branch-2([^HADOOP-15458-branch-2.002.patch]), the test is passed. Please be noted that
I'm using Java 8 in my local Windows machine, the "try-with-resources Statement" was introduced
in Java 7, does it match the Java version for branch-2?

> org.apache.hadoop.fs.TestLocalFileSystem#testFSOutputStreamBuilder fails on Windows
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-15458
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15458
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Xiao Liang
>            Assignee: Xiao Liang
>            Priority: Major
>              Labels: windows
>         Attachments: HADOOP-15458-branch-2.000.patch, HADOOP-15458-branch-2.001.patch,
HADOOP-15458-branch-2.002.patch, HADOOP-15458.000.patch, HADOOP-15458.001.patch, HADOOP-15458.002.patch
>
>
> In *org.apache.hadoop.fs.TestLocalFileSystem#testFSOutputStreamBuilder* a FSDataOutputStream
object is unnecessarily created and not closed, which makes org.apache.hadoop.fs.TestLocalFileSystem#after
fails to delete the folder on Windows.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message