hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15458) org.apache.hadoop.fs.TestLocalFileSystem#testFSOutputStreamBuilder fails on Windows
Date Thu, 24 May 2018 10:16:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488754#comment-16488754
] 

Steve Loughran commented on HADOOP-15458:
-----------------------------------------

-1
The stream.close() should be called even if the assertions are raised.  try-with-resources
can do this easily enough
{code}
try(stream = builder.build) {
 assertions...
}
{code}

> org.apache.hadoop.fs.TestLocalFileSystem#testFSOutputStreamBuilder fails on Windows
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-15458
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15458
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Xiao Liang
>            Assignee: Xiao Liang
>            Priority: Major
>              Labels: windows
>         Attachments: HADOOP-15458-branch-2.000.patch, HADOOP-15458-branch-2.001.patch,
HADOOP-15458.000.patch, HADOOP-15458.001.patch
>
>
> In *org.apache.hadoop.fs.TestLocalFileSystem#testFSOutputStreamBuilder* a FSDataOutputStream
object is unnecessarily created and not closed, which makes org.apache.hadoop.fs.TestLocalFileSystem#after
fails to delete the folder on Windows.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message