From common-issues-return-151641-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Apr 25 23:50:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B7092180676 for ; Wed, 25 Apr 2018 23:50:03 +0200 (CEST) Received: (qmail 1605 invoked by uid 500); 25 Apr 2018 21:50:02 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 1594 invoked by uid 99); 25 Apr 2018 21:50:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Apr 2018 21:50:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 10B821A2509 for ; Wed, 25 Apr 2018 21:50:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id aQLgXxUCw4nX for ; Wed, 25 Apr 2018 21:50:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2BCDD5FCBA for ; Wed, 25 Apr 2018 21:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B236EE0E2A for ; Wed, 25 Apr 2018 21:50:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4C93B241D3 for ; Wed, 25 Apr 2018 21:50:00 +0000 (UTC) Date: Wed, 25 Apr 2018 21:50:00 +0000 (UTC) From: "Ted Yu (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-15392) S3A Metrics in S3AInstrumentation Cause Memory Leaks in HBase Export MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-15392?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 453144#comment-16453144 ]=20 Ted Yu commented on HADOOP-15392: --------------------------------- From S3AInstrumentation : {code} public void close() { synchronized (metricsSystemLock) { metricsSystem.unregisterSource(metricsSourceName); int activeSources =3D --metricsSourceActiveCounter; if (activeSources =3D=3D 0) { metricsSystem.publishMetricsNow(); metricsSystem.shutdown(); metricsSystem =3D null; {code} How about adding a DEBUG log with the value of activeSources so that we kno= w whether the {{activeSources =3D=3D 0}} case is ever reached ? > S3A Metrics in S3AInstrumentation Cause Memory Leaks in HBase Export > -------------------------------------------------------------------- > > Key: HADOOP-15392 > URL: https://issues.apache.org/jira/browse/HADOOP-15392 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 3.1.0 > Reporter: Voyta > Priority: Blocker > > While using HBase S3A Export Snapshot utility we started to experience me= mory leaks of the process after version upgrade. > By running code analysis we traced the cause to revision=C2=A06555af81a26= b0b72ec3bee7034e01f5bd84b1564 that added the following static reference (si= ngleton): > private static MetricsSystem metricsSystem =3D null; > When application uses=C2=A0S3AFileSystem instance that is=C2=A0not closed= immediately metrics are accumulated in this instance and memory grows with= out any limit. > =C2=A0 > Expectation: > * It would be nice to have an option to disable metrics completely as th= is is not needed for Export Snapshot utility. > * Usage of S3AFileSystem should not contain any static object that can g= row indefinitely. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org