From common-issues-return-150724-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Apr 4 16:34:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4DD92180675 for ; Wed, 4 Apr 2018 16:34:04 +0200 (CEST) Received: (qmail 77757 invoked by uid 500); 4 Apr 2018 14:34:03 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 77737 invoked by uid 99); 4 Apr 2018 14:34:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 14:34:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AC20CC0047 for ; Wed, 4 Apr 2018 14:34:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id WEqOrXOQbOcZ for ; Wed, 4 Apr 2018 14:34:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 40B135F189 for ; Wed, 4 Apr 2018 14:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7D89FE00D6 for ; Wed, 4 Apr 2018 14:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3F3C225612 for ; Wed, 4 Apr 2018 14:34:00 +0000 (UTC) Date: Wed, 4 Apr 2018 14:34:00 +0000 (UTC) From: "Andras Bokor (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-15361) RawLocalFileSystem should use Java nio framework for rename MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Bokor updated HADOOP-15361: ---------------------------------- Status: Patch Available (was: Open) > RawLocalFileSystem should use Java nio framework for rename > ----------------------------------------------------------- > > Key: HADOOP-15361 > URL: https://issues.apache.org/jira/browse/HADOOP-15361 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Andras Bokor > Assignee: Andras Bokor > Priority: Major > Labels: incompatibleChange > Attachments: HADOOP-15361.01.patch > > > Currently RawLocalFileSystem uses a fallback logic for cross-volume renames. The fallback logic is a copy-on-fail logic so when rename fails it copies the source then delete it. > An additional fallback logic was needed for Windows to provide POSIX rename behavior. > Due to the fallback logic RawLocalFileSystem does not pass the contract tests (HADOOP-13082). > With using Java nio framework both could be eliminated since it is not platform dependent and provides cross-volume rename. > In addition the fallback logic for Windows is not correct since Java io overrides the destination only if the source is also a directory but handleEmptyDstDirectoryOnWindows method checks only the destination. That means rename allows to override a directory with a file on Windows but not on Unix. > File#renameTo and Files#move are not 100% compatible: > If the source is a directory and the destination is an empty directory File#renameTo overrides the source but Files#move is does not. We have to use {{StandardCopyOption.REPLACE_EXISTING}} but it overrides the destination even if the source or the destination is a file. So to make them compatible we have to check that the either the source or the destination is a directory before we add the copy option. > I think the correct strategy is > * Where the contract test passed so far it should pass after this > * Where the contract test failed because of Java specific think and not because of the fallback logic we should keep the original behavior. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org