From common-issues-return-151701-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Apr 27 03:43:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 966F9180679 for ; Fri, 27 Apr 2018 03:43:04 +0200 (CEST) Received: (qmail 26636 invoked by uid 500); 27 Apr 2018 01:43:03 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 26619 invoked by uid 99); 27 Apr 2018 01:43:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Apr 2018 01:43:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B88C4180112 for ; Fri, 27 Apr 2018 01:43:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id zG4J9rQYr2HL for ; Fri, 27 Apr 2018 01:43:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 55EF05FAEB for ; Fri, 27 Apr 2018 01:43:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7BBF8E010F for ; Fri, 27 Apr 2018 01:43:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3121C20EAB for ; Fri, 27 Apr 2018 01:43:00 +0000 (UTC) Date: Fri, 27 Apr 2018 01:43:00 +0000 (UTC) From: "Aaron Fabbri (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-13756) LocalMetadataStore#put(DirListingMetadata) should also put file metadata into fileHash. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-13756?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 455637#comment-16455637 ]=20 Aaron Fabbri commented on HADOOP-13756: --------------------------------------- +1.=C2=A0 You know it is a good patch when it is a one line fix and ~20 lin= es of test code. Thank you [~gabor.bota] Aside: Since wrote this code I've been thinking I should have probably used= a single hash, {{Path}} -> {{tuple(DirListingMetadata, PathMetadata)}} ins= tead of two separate hashtables.=C2=A0 We could do that as a separate Jira = if we want.. Low priority though. Testing now and will commit if everything works fine. > LocalMetadataStore#put(DirListingMetadata) should also put file metadata = into fileHash. > -------------------------------------------------------------------------= -------------- > > Key: HADOOP-13756 > URL: https://issues.apache.org/jira/browse/HADOOP-13756 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3, test > Affects Versions: 3.0.0-beta1 > Reporter: Lei (Eddy) Xu > Assignee: Gabor Bota > Priority: Major > Attachments: HADOOP-13756.001.patch > > > {{LocalMetadataStore#put(DirListingMetadata)}} only puts the metadata int= o {{dirHash}}, thus all {{FileStatus}} s are missing from {{LocalMedataStor= e#fileHash()}}, which makes it confuse to use. > So in the current way, to correctly put file status into the store (and a= lso set {{authoriative}} flag), you need to run {code} > List metas =3D new ArrayList(); > boolean authorizative =3D true; > for (S3AFileStatus status : files) { > PathMetadata meta =3D new PathMetadata(status); > store.put(meta); > } > DirListingMetadata dirMeta =3D new DirMeta(parent, metas, authorizative); > store.put(dirMeta); > {code} > Since solely calling {{store.put(dirMeta)}} is not correct, and calling {= {store.put(dirMeta);}} after putting all sub-file {{FileStatuss}} does the = repetitive jobs. Can we just use a {{put(PathMetadata)}} and a {{get/setAut= horative()}} in the MetadataStore interface instead? -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org