hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15362) Review of Configuration.java
Date Thu, 12 Apr 2018 02:42:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434852#comment-16434852
] 

BELUGA BEHR commented on HADOOP-15362:
--------------------------------------

[~ajayydv] A public constructor in a private class, is still private.  I was correcting the
following checkstyle errors: :)

 
{code:java}
[ERROR] src/main/java/org/apache/hadoop/conf/Configuration.java:[248,5] (modifier) RedundantModifier:
Redundant 'public' modifier.
[ERROR] src/main/java/org/apache/hadoop/conf/Configuration.java:[252,5] (modifier) RedundantModifier:
Redundant 'public' modifier.
[ERROR] src/main/java/org/apache/hadoop/conf/Configuration.java:[256,5] (modifier) RedundantModifier:
Redundant 'public' modifier.
[ERROR] src/main/java/org/apache/hadoop/conf/Configuration.java:[260,5] (modifier) RedundantModifier:
Redundant 'public' modifier.
[ERROR] src/main/java/org/apache/hadoop/conf/Configuration.java:[377,13] (modifier) RedundantModifier:
Redundant 'final' modifier.
[ERROR] src/main/java/org/apache/hadoop/conf/Configuration.java:[2010,7] (modifier) RedundantModifier:
Redundant 'public' modifier.
{code}

> Review of Configuration.java
> ----------------------------
>
>                 Key: HADOOP-15362
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15362
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HADOOP-15362.1.patch, HADOOP-15362.2.patch, HADOOP-15362.3.patch,
HADOOP-15362.4.patch, HADOOP-15362.5.patch
>
>
> * Various improvements
>  * Fix a lot of checks style errors
> When I ran a recent debug log against a MR job, I was spammed from the following messages. 
I ask that we move them to 'trace' as there is already a debug level logging preceding them.
> {code:java}
> LOG.debug("Handling deprecation for all properties in config");
> foreach item {
> -      LOG.debug("Handling deprecation for " + (String)item);
> +      LOG.trace("Handling deprecation for {}", item);
> }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message