hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rushabh S Shah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15344) LoadBalancingKMSClientProvider#close should not swallow exceptions
Date Thu, 05 Apr 2018 21:05:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427598#comment-16427598
] 

Rushabh S Shah commented on HADOOP-15344:
-----------------------------------------

bq. The exception from the failure is just logged and won't be thrown out.
Yes, you are correct.  LBKMSCP#doOp will succeed.

{code}
finally {
      if (keyProvider != null) {
        keyProvider.close();
      }
{code}
Lets say if one of kmscp threw an exception on close, then it will appear to renew client
that the renew operation failed but it succeeded in reality.
Am I making sense ?


> LoadBalancingKMSClientProvider#close should not swallow exceptions
> ------------------------------------------------------------------
>
>                 Key: HADOOP-15344
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15344
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: kms
>            Reporter: Xiao Chen
>            Assignee: fang zhenyi
>            Priority: Minor
>         Attachments: HADOOP-15344.001.patch
>
>
> As [~shahrs87]'s comment on HADOOP-14445 says:
> {quote}
> LoadBalancingKMSCP never throws IOException back. It just swallows all the IOException
and just logs it.
> ...
> Maybe we might want to return MultipleIOException from LoadBalancingKMSCP#close. 
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message