From common-issues-return-150326-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Mar 26 21:05:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 960B6180671 for ; Mon, 26 Mar 2018 21:05:04 +0200 (CEST) Received: (qmail 79643 invoked by uid 500); 26 Mar 2018 19:05:03 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 79632 invoked by uid 99); 26 Mar 2018 19:05:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Mar 2018 19:05:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id F2015182D82 for ; Mon, 26 Mar 2018 19:05:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3y5Jvmzyjioy for ; Mon, 26 Mar 2018 19:05:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9C19D5F523 for ; Mon, 26 Mar 2018 19:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D0826E0E28 for ; Mon, 26 Mar 2018 19:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 836B9214F9 for ; Mon, 26 Mar 2018 19:05:00 +0000 (UTC) Date: Mon, 26 Mar 2018 19:05:00 +0000 (UTC) From: "Ajay Kumar (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HADOOP-15343) NetworkTopology#getLoc should exit loop earlier rather than traverse all children MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-15343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414335#comment-16414335 ] Ajay Kumar edited comment on HADOOP-15343 at 3/26/18 7:04 PM: -------------------------------------------------------------- +1, Would be great if we can add a test case. (Since getLoc is private may be can use getNode) was (Author: ajayydv): +1 > NetworkTopology#getLoc should exit loop earlier rather than traverse all children > --------------------------------------------------------------------------------- > > Key: HADOOP-15343 > URL: https://issues.apache.org/jira/browse/HADOOP-15343 > Project: Hadoop Common > Issue Type: Improvement > Components: performance > Affects Versions: 2.7.6 > Reporter: He Xiaoqiao > Priority: Major > Labels: performance > Attachments: HADOOP-15343-branch-2.7.001.patch > > > NetworkTopology#getLoc return a proper node after traverse ALL children of current {{InnerNode}} even if it has found expected result, based on branch-2.7. This issue may lead some performance loss especially for a large & busy cluster and many nodes under a rack. I think it should exit loop earlier rather than traverse all children of {{InnerNode}}. > {code:java} > private Node getLoc(String loc) { > if (loc == null || loc.length() == 0) return this; > > String[] path = loc.split(PATH_SEPARATOR_STR, 2); > Node childnode = null; > for(int i=0; i if (children.get(i).getName().equals(path[0])) { > childnode = children.get(i); > } > } > if (childnode == null) return null; // non-existing node > if (path.length == 1) return childnode; > if (childnode instanceof InnerNode) { > return ((InnerNode)childnode).getLoc(path[1]); > } else { > return null; > } > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org