From common-issues-return-150416-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Mar 28 02:33:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9CE7818064E for ; Wed, 28 Mar 2018 02:33:03 +0200 (CEST) Received: (qmail 57802 invoked by uid 500); 28 Mar 2018 00:33:02 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 57788 invoked by uid 99); 28 Mar 2018 00:33:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Mar 2018 00:33:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 002E518030B for ; Wed, 28 Mar 2018 00:33:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ZgyjzBsPaGCK for ; Wed, 28 Mar 2018 00:33:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1F3875F5B2 for ; Wed, 28 Mar 2018 00:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7CE42E0D76 for ; Wed, 28 Mar 2018 00:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2C8462150F for ; Wed, 28 Mar 2018 00:33:00 +0000 (UTC) Date: Wed, 28 Mar 2018 00:33:00 +0000 (UTC) From: "Chris Douglas (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-15320) Remove customized getFileBlockLocations for hadoop-azure and hadoop-azure-datalake MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-15320?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Douglas updated HADOOP-15320: ----------------------------------- Attachment: HADOOP-15320.01.patch > Remove customized getFileBlockLocations for hadoop-azure and hadoop-azure= -datalake > -------------------------------------------------------------------------= --------- > > Key: HADOOP-15320 > URL: https://issues.apache.org/jira/browse/HADOOP-15320 > Project: Hadoop Common > Issue Type: Bug > Components: fs/adl, fs/azure > Affects Versions: 2.7.3, 2.9.0, 3.0.0 > Reporter: shanyu zhao > Assignee: shanyu zhao > Priority: Major > Attachments: HADOOP-15320.01.patch, HADOOP-15320.patch > > > hadoop-azure and hadoop-azure-datalake have its own implementation of get= FileBlockLocations(), which faked a list of artificial blocks based on the = hard-coded block size. And each block has one host with name "localhost". T= ake a look at this code: > [https://github.com/apache/hadoop/blob/release-2.9.0-RC3/hadoop-tools/had= oop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.ja= va#L3485] > This is a unnecessary mock up for a "remote" file system to mimic HDFS. A= nd the problem with this mock is that for large (~TB) files we generates lo= ts of artificial blocks, and FileInputFormat.getSplits() is slow in calcula= ting splits based on these blocks. > We can safely remove this customized getFileBlockLocations() implementati= on, fall back to the default FileSystem.getFileBlockLocations() implementat= ion, which is to return 1 block for any file with 1 host "localhost". Note = that this doesn't mean we will create much less splits, because the number = of splits is still=C2=A0limited by the blockSize in FileInputFormat.compute= SplitSize(): > {code:java} > return Math.max(minSize, Math.min(goalSize, blockSize));{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org