hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15313) TestKMS should close providers
Date Fri, 23 Mar 2018 20:43:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412037#comment-16412037

Wei-Chiu Chuang commented on HADOOP-15313:

Thanks for the patch. Nice approach to capture them all. 

I think you'll also need to add a provider into providersCreated in createKMSClientProvider().

A few places where the provider is expliictly closed, like at line 475
and at line 502, line 520, line 2197

> TestKMS should close providers
> ------------------------------
>                 Key: HADOOP-15313
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15313
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: kms, test
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>            Priority: Major
>         Attachments: HADOOP-15313.01.patch, HADOOP-15313.02.patch
> During the review of HADOOP-14445, [~jojochuang] found that we key providers are not
closed in tests. Details in [this comment|https://issues.apache.org/jira/browse/HADOOP-14445?focusedCommentId=16397824&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16397824].
> We should investigate and handle that in all related tests.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message