hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SammiChen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15262) AliyunOSS: rename() to move files in a directory in parallel
Date Mon, 05 Mar 2018 04:45:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385603#comment-16385603
] 

SammiChen commented on HADOOP-15262:
------------------------------------

Some comments:

1.  Indent is 4 black spaces instead of 8 black spaces in Hadoop code style. 

2.  The comment style is not consistent in Constants class.  Leave a space between // and
the, and also "the" should begin with upper case "T". 

//maximum number of threads allowed in the pool for copies

3. Import with wildcast "*"  is strongly not recommended by Hadoop code style. 

import static org.junit.Assert.*;

4.  function parameter list coding style,  please refer to AliyunOSSInputStream to improve
the AliyunOSSCopyFileTask parameter list style. 
5.  unboundedCopyThreadPool. Suggest set a upper limit to waiting list size. Using unbound
resource is not recommended. 
6.  lock before check the status
    if (copyFileContext.isCopyFailure()) {
          //some error occurs, break
          break;
    }	  


> AliyunOSS: rename() to move files in a directory in parallel
> ------------------------------------------------------------
>
>                 Key: HADOOP-15262
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15262
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/oss
>    Affects Versions: 3.0.0
>            Reporter: wujinhu
>            Assignee: wujinhu
>            Priority: Major
>             Fix For: 3.1.0, 2.9.1, 3.0.1
>
>         Attachments: HADOOP-15262.001.patch, HADOOP-15262.002.patch, HADOOP-15262.003.patch
>
>
> Currently, rename() operation renames files in series. This will be slow if a directory
contains many files. So we can improve this by rename files in parallel.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message