hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Fourny (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-15217) org.apache.hadoop.fs.FsUrlConnection does not handle paths with spaces
Date Thu, 08 Feb 2018 22:31:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Joseph Fourny updated HADOOP-15217:
-----------------------------------
    Description: 
When _FsUrlStreamHandlerFactory_ is registered with _java.net.URL_ (ex: when Spark is initialized),
it breaks URLs with spaces (even though they are properly URI-encoded). I traced the problem
down to _FSUrlConnection.connect()_ method. It naively gets the path from the URL, which
contains encoded spaces, and pases it to _org.apache.hadoop.fs.Path(String)_ constructor.
This is not correct, because the docs clearly say that the string must NOT be encoded. Doing
so causes double encoding within the Path class (ie: %20 becomes %2520). 

See attached JUnit test. 

This test case mimics and issue I ran into when trying to use Commons Configuration 1.9 AFTER
initializing Spark. Commons Configuration uses URL class to load configuration files, but
Spark installs _FsUrlStreamHandlerFactory_, which hits this issue. For now, we are using
an AspectJ aspect to "patch" the bytecode at load time to work-around the issue. 

The real fix is quite simple. All you need to do is replace this line in _org.apache.hadoop.fs.FsUrlConnection.connect()_:
        is = fs.open(new Path(url.getPath()));

with this line:

     is = fs.open(new Path(url.*toUri()*.getPath()));

URI.getPath() will correctly decode the path, which is what is expected by _org.apache.hadoop.fs.Path(String)_ constructor.

 

  was:
When _FsUrlStreamHandlerFactory_ is registered with _java.net.URL_ (ex: when Spark is initialized),
it breaks URLs with spaces (even though they are properly URI-encoded). I traced the problem
down to _FSUrlConnection.connect()_ method. It naively gets the path from the URL, which
contains encoded spaces, and pases it to _org.apache.hadoop.fs.Path(String)_ constructor.
This is not correct, because the docs clearly say that the string must NOT be encoded. Doing
so causes double encoding within the Path class (ie: %20 becomes %2520). 

See attached JUnit test. 

This test case mimics and issue I ran into when trying to use Commons Configuration 1.9 AFTER
initializing Spark. Commons Configuration uses URL class to load configuration files, but
Spark installs _FsUrlStreamHandlerFactory_, which hits this issue. For now, we are using
an AspectJ aspect to "patch" the bytecode at load time to work-around the issue. 

The real fix is quite simple. All you need to do is replace this line:
        is = fs.open(new Path(url.getPath()));

with this line:

     is = fs.open(new Path(url.*toUri()*.getPath()));

URI.getPath() will correctly decode the path, which is what is expected by _org.apache.hadoop.fs.Path(String)_ constructor.

 


> org.apache.hadoop.fs.FsUrlConnection does not handle paths with spaces
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-15217
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15217
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.6.5
>            Reporter: Joseph Fourny
>            Priority: Major
>         Attachments: TestCase.java
>
>
> When _FsUrlStreamHandlerFactory_ is registered with _java.net.URL_ (ex: when Spark is
initialized), it breaks URLs with spaces (even though they are properly URI-encoded). I traced
the problem down to _FSUrlConnection.connect()_ method. It naively gets the path from the
URL, which contains encoded spaces, and pases it to _org.apache.hadoop.fs.Path(String)_ constructor.
This is not correct, because the docs clearly say that the string must NOT be encoded. Doing
so causes double encoding within the Path class (ie: %20 becomes %2520). 
> See attached JUnit test. 
> This test case mimics and issue I ran into when trying to use Commons Configuration 1.9
AFTER initializing Spark. Commons Configuration uses URL class to load configuration files,
but Spark installs _FsUrlStreamHandlerFactory_, which hits this issue. For now, we are using
an AspectJ aspect to "patch" the bytecode at load time to work-around the issue. 
> The real fix is quite simple. All you need to do is replace this line in _org.apache.hadoop.fs.FsUrlConnection.connect()_:
>         is = fs.open(new Path(url.getPath()));
> with this line:
>      is = fs.open(new Path(url.*toUri()*.getPath()));
> URI.getPath() will correctly decode the path, which is what is expected by _org.apache.hadoop.fs.Path(String)_ constructor.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message