hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andras Bokor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14178) Move Mockito up to version 2.x
Date Tue, 13 Feb 2018 14:21:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362385#comment-16362385

Andras Bokor commented on HADOOP-14178:


I went through on the patch again considering your comments above and I found 2 additional
 1. TestLocalizedResource: 
 {{public boolean matches(LocalizerEvent o)}}
 Here o could be renamed to renamed le or something as at other places where matches method
was changed.
 This is very minor so feel free to ignore.

junit must be before mockito-core on the classpath. mockito-core bundles its
     own copy of the hamcrest classes, but they don't match our junit version.{code}
is not true. These sentences should be removed instead of modifing. Mocito-core does not does
not include hamcrest classes.


That is all from my side.

> Move Mockito up to version 2.x
> ------------------------------
>                 Key: HADOOP-14178
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14178
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 2.9.0
>            Reporter: Steve Loughran
>            Assignee: Akira Ajisaka
>            Priority: Major
>         Attachments: HADOOP-14178.001.patch, HADOOP-14178.002.patch, HADOOP-14178.003.patch,
HADOOP-14178.004.patch, HADOOP-14178.005-wip.patch, HADOOP-14178.005-wip2.patch, HADOOP-14178.005-wip3.patch,
HADOOP-14178.005-wip4.patch, HADOOP-14178.005-wip5.patch, HADOOP-14178.005-wip6.patch, HADOOP-14178.005.patch,
HADOOP-14178.006.patch, HADOOP-14178.007.patch
> I don't know when Hadoop picked up Mockito, but it has been frozen at 1.8.5 since the
switch to maven in 2011. 
> Mockito is now at version 2.1, [with lots of Java 8 support|https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2].
That' s not just defining actions as closures, but in supporting Optional types, mocking methods
in interfaces, etc. 
> It's only used for testing, and, *provided there aren't regressions*, cost of upgrade
is low. The good news: test tools usually come with good test coverage. The bad: mockito does
go deep into java bytecodes.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message