From common-issues-return-147286-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Sat Jan 27 01:07:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5A36D180657 for ; Sat, 27 Jan 2018 01:07:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 498E4160C50; Sat, 27 Jan 2018 00:07:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 93703160C2E for ; Sat, 27 Jan 2018 01:07:05 +0100 (CET) Received: (qmail 45595 invoked by uid 500); 27 Jan 2018 00:07:04 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 45584 invoked by uid 99); 27 Jan 2018 00:07:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Jan 2018 00:07:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2F98F1A146E for ; Sat, 27 Jan 2018 00:07:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.311 X-Spam-Level: X-Spam-Status: No, score=-102.311 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id cXUMfltO6_f1 for ; Sat, 27 Jan 2018 00:07:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CB2DF5FBBC for ; Sat, 27 Jan 2018 00:07:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EFD65E00C7 for ; Sat, 27 Jan 2018 00:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5FE1624112 for ; Sat, 27 Jan 2018 00:07:00 +0000 (UTC) Date: Sat, 27 Jan 2018 00:07:00 +0000 (UTC) From: "Jason Lowe (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-15170) Add symlink support to FileUtil#unTarUsingJava MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341831#comment-16341831 ] Jason Lowe commented on HADOOP-15170: ------------------------------------- Thanks for the patch! Apologies for the delay. The VisibleForTesting import looks shady (pun intended). We should be pulling this in from the normal location. Actually even better would be to simply make this package-private rather than public. Then I would argue the visibility marker isn't necessary. The createSymbolicLinkUsingJava does not seem worth it given it's private and it's less typing to call the Files method directly. > Add symlink support to FileUtil#unTarUsingJava > ----------------------------------------------- > > Key: HADOOP-15170 > URL: https://issues.apache.org/jira/browse/HADOOP-15170 > Project: Hadoop Common > Issue Type: Improvement > Components: util > Reporter: Jason Lowe > Assignee: Ajay Kumar > Priority: Minor > Attachments: HADOOP-15170.001.patch, HADOOP-15170.002.patch > > > Now that JDK7 or later is required, we can leverage java.nio.Files.createSymbolicLink in FileUtil.unTarUsingJava to support archives that contain symbolic links. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org