From common-issues-return-147376-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Jan 30 23:47:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 4252C18061A for ; Tue, 30 Jan 2018 23:47:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 32549160C54; Tue, 30 Jan 2018 22:47:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 82C86160C2A for ; Tue, 30 Jan 2018 23:47:04 +0100 (CET) Received: (qmail 54996 invoked by uid 500); 30 Jan 2018 22:47:03 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 54983 invoked by uid 99); 30 Jan 2018 22:47:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jan 2018 22:47:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1A58D1A473A for ; Tue, 30 Jan 2018 22:47:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id WtrvvZYYfBcj for ; Tue, 30 Jan 2018 22:47:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BDB7F5F613 for ; Tue, 30 Jan 2018 22:47:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E9044E0217 for ; Tue, 30 Jan 2018 22:47:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 41D85240F6 for ; Tue, 30 Jan 2018 22:47:00 +0000 (UTC) Date: Tue, 30 Jan 2018 22:47:00 +0000 (UTC) From: "Hanisha Koneru (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10571) Use Log.*(Object, Throwable) overload to log exceptions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10571?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 345939#comment-16345939 ]=20 Hanisha Koneru commented on HADOOP-10571: ----------------------------------------- Thanks for working on this [~boky01].=C2=A0 In the files modified in the patch, there are a lot of other log messages w= hich also need to be fixed to=C2=A0avoid string concatenation. For example,= lines {{142, 175, 178, 230, 235}} in=C2=A0{{FailoverController}}. It would= be good to fix all the log messages in a file at once.=20 Covering all the files at once would become huge. We can break this down in= to sub-tasks of HDFS-12829. > Use Log.*(Object, Throwable) overload to log exceptions > ------------------------------------------------------- > > Key: HADOOP-10571 > URL: https://issues.apache.org/jira/browse/HADOOP-10571 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.4.0 > Reporter: Arpit Agarwal > Assignee: Andras Bokor > Priority: Major > Attachments: HADOOP-10571.01.patch, HADOOP-10571.01.patch > > > When logging an exception, we often convert the exception to string or ca= ll {{.getMessage}}. Instead we can use the log method overloads which take = {{Throwable}} as a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org