hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanisha Koneru (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-14788) Credentials readTokenStorageFile to stop wrapping IOEs in IOEs
Date Mon, 08 Jan 2018 23:45:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317282#comment-16317282
] 

Hanisha Koneru edited comment on HADOOP-14788 at 1/8/18 11:44 PM:
------------------------------------------------------------------

[~ajayydv], I am still not sure why the exception should be changed to PathIOException. I
might be missing something here. Steve, can you please clarify. Thanks.
PathIOException is for "Exceptions based on standard posix/linux style exceptions for path
related errors". Instead, can we add the path to the IOException message?


was (Author: hanishakoneru):
[~ajayydv], I am still not sure why the exception should be changed to PathIOException. I
might be missing something here. Steve, can you please clarify. Thanks.

> Credentials readTokenStorageFile to stop wrapping IOEs in IOEs
> --------------------------------------------------------------
>
>                 Key: HADOOP-14788
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14788
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.8.1
>            Reporter: Steve Loughran
>            Assignee: Ajay Kumar
>            Priority: Minor
>         Attachments: HADOOP-14788.001.patch, HADOOP-14788.002.patch, HADOOP-14788.003.patch,
HADOOP-14788.004.patch
>
>
> When {{Credentials readTokenStorageFile}} gets an IOE. it catches & wraps with the
filename, so losing the exception class information.
> Is this needed. or can it pass everything up?
> If it is needed, well, it's a common pattern: wrapping the exception with the path &
operation. Maybe it's time to add an IOE version of {{NetworkUtils.wrapException()}} which
handles the broader set of IOEs



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message