hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanisha Koneru (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10571) Use Log.*(Object, Throwable) overload to log exceptions
Date Tue, 30 Jan 2018 22:47:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345939#comment-16345939
] 

Hanisha Koneru commented on HADOOP-10571:
-----------------------------------------

Thanks for working on this [~boky01]. 

In the files modified in the patch, there are a lot of other log messages which also need
to be fixed to avoid string concatenation. For example, lines {{142, 175, 178, 230, 235}}
in {{FailoverController}}. It would be good to fix all the log messages in a file at once.


Covering all the files at once would become huge. We can break this down into sub-tasks of
HDFS-12829.

> Use Log.*(Object, Throwable) overload to log exceptions
> -------------------------------------------------------
>
>                 Key: HADOOP-10571
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10571
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Arpit Agarwal
>            Assignee: Andras Bokor
>            Priority: Major
>         Attachments: HADOOP-10571.01.patch, HADOOP-10571.01.patch
>
>
> When logging an exception, we often convert the exception to string or call {{.getMessage}}.
Instead we can use the log method overloads which take {{Throwable}} as a parameter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message