Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 4 Dec 2017 14:30:00 +0000 (UTC)
From: "Steve Loughran (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13122481.1512360206000.378523.1512397800039@Atlassian.JIRA>
In-Reply-To: <JIRA.13122481.1512360206000@Atlassian.JIRA>
References: <JIRA.13122481.1512360206000@Atlassian.JIRA> <JIRA.13122481.1512360206700@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HADOOP-15088) BufferedInputStream.skip function
 can return 0 when the file is corrupted, causing an infinite loop
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 04 Dec 2017 14:30:04 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-15088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276846#comment-16276846 ] 

Steve Loughran commented on HADOOP-15088:
-----------------------------------------

Probably a common bug we've copied and pasted around. Why not add a new IOUtil operation to do this, as other streams may do the same, especially the object stores

> BufferedInputStream.skip function can return 0 when the file is corrupted, causing an infinite loop
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-15088
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15088
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: streaming
>    Affects Versions: 2.5.0
>            Reporter: John Doe
>
> When a file is corrupted, the skip function can return 0, causing an infinite loop.
> Here is the code:
> {code:java}
>   private boolean slowReadUntilMatch(Pattern markPattern, boolean includePat,
>                                      DataOutputBuffer outBufOrNull) throws IOException {
>       ...
>       for (long skiplen = endPos; skiplen > 0; ) {
>         skiplen -= bin_.skip(skiplen); 
>       }
>       ...
>   }
> {code}
> Similar bugs are [Hadoop-8614|https://issues.apache.org/jira/browse/HADOOP-8614], [Yarn-2905|https://issues.apache.org/jira/browse/YARN-2905], [Yarn-163|https://issues.apache.org/jira/browse/YARN-163], [MAPREDUCE-6990|https://issues.apache.org/jira/browse/MAPREDUCE-6990]


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org