Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 8 Dec 2017 05:05:00 +0000 (UTC)
From: "Xiao Chen (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13119835.1511240910000.415339.1512709500118@Atlassian.JIRA>
In-Reply-To: <JIRA.13119835.1511240910000@Atlassian.JIRA>
References: <JIRA.13119835.1511240910000@Atlassian.JIRA> <JIRA.13119835.1511240910237@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HADOOP-15056) Fix
 TestUnbuffer#testUnbufferException failure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 08 Dec 2017 05:05:04 -0000


     [ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xiao Chen updated HADOOP-15056:
-------------------------------
    Component/s: test

> Fix TestUnbuffer#testUnbufferException failure
> ----------------------------------------------
>
>                 Key: HADOOP-15056
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15056
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.9.0
>            Reporter: Jack Bearden
>            Assignee: Jack Bearden
>            Priority: Minor
>         Attachments: HADOOP-15056.001.patch, HADOOP-15056.002.patch, HADOOP-15056.003.patch, HADOOP-15056.004.patch, HADOOP-15056.005.patch, HADOOP-15056.006.patch, HADOOP-15056.007.patch
>
>
> Hello! I am a new contributor and actually contributing to open source for the very first time. :) 
> I pulled down Hadoop today and when running the tests I encountered a failure with the TestUnbuffer#testUnbufferException test.
> The unbuffer code has recently gone through some changes and I believe this test case may have been overlooked. Using today's git commit (659e85e304d070f9908a96cf6a0e1cbafde6a434), and upon running the test case, there is an expect mock for an exception UnsupportedOperationException that is no longer being thrown. 
> It would appear that a test like this would be valuable so my initial proposed patch did not remove it. Instead, I removed the conditions that were guarding the cast from being able to fire -- as was the previous behavior. Now when we encounter an object that doesn't have the UNBUFFERED StreamCapability, it will throw an error as it did prior to the recent changes. 
> Please review and let me know what you think! :D


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org