hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanisha Koneru (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15128) TestViewFileSystem tests are broken in trunk
Date Wed, 20 Dec 2017 18:57:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298921#comment-16298921
] 

Hanisha Koneru commented on HADOOP-15128:
-----------------------------------------

Thanks [~eyang] and [~stevel@apache.org] for the insights.

We can override the _toString()_ function in {{ViewFsFileStatus}} and {{ViewFsLocatedFileStatus}}.
The rest of the classes extending FileStatus either override the toString() function already
or do not override any of the get methods (_getPath()_, _isDirectory()_ etc.) we want to introduce
in toString() ( with the exception of DeprecatedRawLocalFileSystem).

{{DeprecatedRawLocalFileSystem#toString()}} would remain the same as is (calliing _FileStatus#toString()_).
The toString() output might not give the actual owner,  group and permission correctly. But
it would avoid the calls to _loadPermissionInfo()_ every time toString() is called. And there
won't be any modifications done to {{FileStatus}}.

> TestViewFileSystem tests are broken in trunk
> --------------------------------------------
>
>                 Key: HADOOP-15128
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15128
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: viewfs
>    Affects Versions: 3.1.0
>            Reporter: Anu Engineer
>            Assignee: Hanisha Koneru
>
> The fix in Hadoop-10054 seems to have caused a test failure. Please take a look. Thanks
[~eyang] for reporting this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message