hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15106) FileSystem::open(PathHandle) should throw a specific exception on validation failure
Date Thu, 14 Dec 2017 19:08:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291380#comment-16291380
] 

Chris Douglas commented on HADOOP-15106:
----------------------------------------

bq. Is there any unit test covering this?
Yes, the contract tests. I added more checks as part of HDFS-12882, but they're not exhaustive.
The negative cases are updated to catch {{InvalidPathHandleException}} instead of {{IOException}}
in the patch.

bq. How about moving InvalidPathHandleException above IOException in the javadoc to be consistent
with others like getFileStatus (e.g., FileNotFoundException goes above IOException)
Sure, np.

> FileSystem::open(PathHandle) should throw a specific exception on validation failure
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-15106
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15106
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: HADOOP-15106.00.patch, HADOOP-15106.01.patch, HADOOP-15106.02.patch,
HADOOP-15106.03.patch
>
>
> Callers of {{FileSystem::open(PathHandle)}} cannot distinguish between I/O errors and
an invalid handle. The signature should include a specific, checked exception for this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message