hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Brennan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-15085) Output streams closed with IOUtils suppressing write errors
Date Wed, 13 Dec 2017 15:53:02 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-15085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Jim Brennan updated HADOOP-15085:
    Attachment: HADOOP-15085.005.patch

Uploaded a new patch that addresses the issues raised in the review.

> Output streams closed with IOUtils suppressing write errors
> -----------------------------------------------------------
>                 Key: HADOOP-15085
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15085
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Jason Lowe
>            Assignee: Jim Brennan
>         Attachments: HADOOP-15085.001.patch, HADOOP-15085.002.patch, HADOOP-15085.003.patch,
HADOOP-15085.004.patch, HADOOP-15085.005.patch
> There are a few places in hadoop-common that are closing an output stream with IOUtils.cleanupWithLogger
like this:
> {code}
>   try {
>     ...write to outStream...
>   } finally {
>     IOUtils.cleanupWithLogger(LOG, outStream);
>   }
> {code}
> This suppresses any IOException that occurs during the close() method which could lead
to partial/corrupted output without throwing a corresponding exception.  The code should either
use try-with-resources or explicitly close the stream within the try block so the exception
thrown during close() is properly propagated as exceptions during write operations are.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message