hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Kumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14788) Credentials readTokenStorageFile to stop wrapping IOEs in IOEs
Date Thu, 14 Dec 2017 17:59:02 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291276#comment-16291276

Ajay Kumar commented on HADOOP-14788:

[~hanishakoneru] thanks for review. In patch v1 IOException was returned. Changed it to PathIOException
on [~stevel@apache.org] [suggestion|https://issues.apache.org/jira/browse/HADOOP-14788?focusedCommentId=16183926&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16183926]
(Assuming i understood it correctly. :)). 

In the method description of wrapException, "if exception" string is repeated.
Thanks for catching that, addressed in patch v4.

> Credentials readTokenStorageFile to stop wrapping IOEs in IOEs
> --------------------------------------------------------------
>                 Key: HADOOP-14788
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14788
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.8.1
>            Reporter: Steve Loughran
>            Assignee: Ajay Kumar
>            Priority: Minor
>         Attachments: HADOOP-14788.001.patch, HADOOP-14788.002.patch, HADOOP-14788.003.patch
> When {{Credentials readTokenStorageFile}} gets an IOE. it catches & wraps with the
filename, so losing the exception class information.
> Is this needed. or can it pass everything up?
> If it is needed, well, it's a common pattern: wrapping the exception with the path &
operation. Maybe it's time to add an IOE version of {{NetworkUtils.wrapException()}} which
handles the broader set of IOEs

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message