hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14594) ITestS3AFileOperationCost::testFakeDirectoryDeletion to uncomment metric assertions
Date Fri, 01 Dec 2017 12:09:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274315#comment-16274315
] 

Steve Loughran commented on HADOOP-14594:
-----------------------------------------

given that old patch uncomments things, the revert will leave the asserts commented out. I'd
prefer deleting them entirely. If you supply a patch for that, I'll review

> ITestS3AFileOperationCost::testFakeDirectoryDeletion to uncomment metric assertions
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-14594
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14594
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>             Fix For: 2.9.0, 3.0.0-alpha4
>
>         Attachments: HADOOP-14594.000.patch, HADOOP-14594.001.patch
>
>
> Per discussion [HADOOP-14255] and [HADOOP-13222], we can delete the TODO comment in tests
for metric assertions.
> See the attached patch for more details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message