Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 2 Nov 2017 16:22:00 +0000 (UTC)
From: "Robert Kanter (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13113380.1509473674000.132842.1509639720602@Atlassian.JIRA>
In-Reply-To: <JIRA.13113380.1509473674000@Atlassian.JIRA>
References: <JIRA.13113380.1509473674000@Atlassian.JIRA> <JIRA.13113380.1509473674004@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HADOOP-14998) Make AuthenticationFilter @Public
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 02 Nov 2017 16:22:07 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-14998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236048#comment-16236048 ] 

Robert Kanter commented on HADOOP-14998:
----------------------------------------

{quote}Risk here is that it's getting close to jetty & kerberos, where changes over versions can be observable.{quote}
That's a valid thing to be concerned about.  However, we didn't have to change anything in {{AuthenticationFilter}} when moving from Jetty 6 to 9 (HADOOP-10075).  The stability here is probably due to the Java interface, {{javax.servlet.Filter}}.  At the least, we could make the {{javax.servlet.Filter}} methods public and leave some of the custom methods private or unstable.

> Make AuthenticationFilter @Public
> ---------------------------------
>
>                 Key: HADOOP-14998
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14998
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0
>            Reporter: Robert Kanter
>            Assignee: Bharat Viswanadham
>            Priority: Major
>
> {{org.apache.hadoop.security.authentication.server.AuthenticationFilter}} is currently marked as {{\@Private}} and {{\@Unstable}}.  
> {code:java}
> @InterfaceAudience.Private
> @InterfaceStability.Unstable
> public class AuthenticationFilter implements Filter {
> {code}
> However, many other projects (e.g. Oozie, Hive, Solr, HBase, etc) have been using it for quite some time without having any compatibility issues AFAIK.  It doesn't seem to have had any breaking changes in quite some time.  On top of that, it implements {{javax.servlet.Filter}}, so it can't change too widely anyway.  {{AuthenticationFilter}} provides a lot of useful code for dealing with tokens, Kerberos, etc, and we should encourage related projects to re-use this code instead of rolling their own.
> I propose we change it to {{\@Public}} and {{\@Evolving}}.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org