hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-15069) support git-secrets commit hook to keep AWS secrets out of git
Date Thu, 23 Nov 2017 15:42:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Steve Loughran updated HADOOP-15069:
------------------------------------
    Attachment: HADOOP-15069-001.patch

Patch 001: adds docs and the .gitallow file to stop false positives

test: git secrets -scan works
git secrets -scan-history is still ongoing; if it throws up problems I'll add them to the
patten list too, so that 

You can check that git-secrets does a scan by having it scan the hadoop source tree without
the .gitallow file & see how it finds strings which match its AWS rexeps

+we could also check for azure secrets, if we knew their patten

> support git-secrets commit hook to keep AWS secrets out of git
> --------------------------------------------------------------
>
>                 Key: HADOOP-15069
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15069
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-15069-001.patch
>
>
> The latest Uber breach looks like it involved AWS keys in git repos.
> Nobody wants that, which is why amazon provide [git-secrets|https://github.com/awslabs/git-secrets];
a script you can use to scan a repo and its history, *and* add as an automated check.
> Anyone can set this up, but there are a few false positives in the scan, mostly from
longs and a few all-upper-case constants. These can all be added to a .gitignore file.
> Also: mention git-secrets in the aws testing docs; say "use it"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message