hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15067) GC time percentage reported in JvmMetrics should be a gauge, not counter
Date Thu, 23 Nov 2017 17:23:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264636#comment-16264636
] 

Hudson commented on HADOOP-15067:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13275 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13275/])
HADOOP-15067. GC time percentage reported in JvmMetrics should be a (xiao: rev d162252d7a7223631ff66ba0210953296407e55f)
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java
* (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java


> GC time percentage reported in JvmMetrics should be a gauge, not counter
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-15067
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15067
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Misha Dmitriev
>            Assignee: Misha Dmitriev
>             Fix For: 3.0.0, 2.10.0
>
>         Attachments: HADOOP-15067.01.patch
>
>
> A new GcTimeMonitor class has been recently added, and the corresponding metrics added
in JvmMetrics.java, line 190:
> {code}
>     if (gcTimeMonitor != null) {
>       rb.addCounter(GcTimePercentage,
>           gcTimeMonitor.getLatestGcData().getGcTimePercentage());
>     }
> {code}
> Since GC time percentage can go up and down, a gauge rather than counter should be used
to report it. That is, {{addCounter}} should be replaced with {{addGauge}} above.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message