Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 25 Oct 2017 16:28:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13111106.1508536257000.58018.1508948880244@Atlassian.JIRA>
In-Reply-To: <JIRA.13111106.1508536257000@Atlassian.JIRA>
References: <JIRA.13111106.1508536257000@Atlassian.JIRA> <JIRA.13111106.1508536257792@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HADOOP-14971) Merge S3A committers into trunk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 25 Oct 2017 16:28:07 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218999#comment-16218999 ] 

ASF GitHub Bot commented on HADOOP-14971:
-----------------------------------------

Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/282#discussion_r146912753
  
    --- Diff: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/staging/Paths.java ---
    @@ -0,0 +1,306 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.hadoop.fs.s3a.commit.staging;
    +
    +import java.io.IOException;
    +import java.net.URI;
    +import java.util.List;
    +import java.util.Random;
    +import java.util.Set;
    +
    +import com.google.common.base.Objects;
    +import com.google.common.base.Preconditions;
    +import com.google.common.collect.Sets;
    +
    +import org.apache.commons.lang.StringUtils;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.fs.FileStatus;
    +import org.apache.hadoop.fs.FileSystem;
    +import org.apache.hadoop.fs.Path;
    +import org.apache.hadoop.fs.PathFilter;
    +import org.apache.hadoop.fs.PathIsDirectoryException;
    +import org.apache.hadoop.mapreduce.MRJobConfig;
    +import org.apache.hadoop.mapreduce.TaskAttemptID;
    +import org.apache.hadoop.security.UserGroupInformation;
    +
    +import static org.apache.hadoop.fs.s3a.Constants.BUFFER_DIR;
    +import static org.apache.hadoop.fs.s3a.commit.CommitConstants.*;
    +import static org.apache.hadoop.fs.s3a.commit.staging.StagingCommitterConstants.*;
    +
    +/**
    + * Path operations for the staging committers.
    + */
    +public final class Paths {
    +
    +  private Paths() {
    +  }
    +
    +  /**
    +   * Insert the UUID to a path if it is not there already.
    +   * If there is a trailing "." in the prefix after the last slash, the
    +   * UUID is inserted before it with a "-" prefix; otherwise appended.
    +   *
    +   * Examples:
    +   * <pre>
    +   *   /example/part-0000  ==&gt; /example/part-0000-0ab34
    +   *   /example/part-0001.gz.csv  ==&gt; /example/part-0001-0ab34.gz.csv
    +   *   /example/part-0002-0abc3.gz.csv  ==&gt; /example/part-0002-0abc3.gz.csv
    +   *   /example0abc3/part-0002.gz.csv  ==&gt; /example0abc3/part-0002.gz.csv
    +   * </pre>
    +   *
    +   *
    +   * @param pathStr path as a string; must not have a trailing "/".
    +   * @param uuid UUID to append; must not be empty
    +   * @return new path.
    +   */
    +  public static String addUUID(String pathStr, String uuid) {
    +    Preconditions.checkArgument(StringUtils.isNotEmpty(pathStr), "empty path");
    +    Preconditions.checkArgument(StringUtils.isNotEmpty(uuid), "empty uuid");
    +    // In some cases, Spark will add the UUID to the filename itself.
    +    if (pathStr.contains(uuid)) {
    +      return pathStr;
    +    }
    +
    +    int dot; // location of the first '.' in the file name
    +    int lastSlash = pathStr.lastIndexOf('/');
    +    if (lastSlash >= 0) {
    +      Preconditions.checkState(lastSlash + 1 < pathStr.length(),
    +          "Bad path: " + pathStr);
    +      dot = pathStr.indexOf('.', lastSlash);
    +    } else {
    +      dot = pathStr.indexOf('.');
    +    }
    +
    +    if (dot >= 0) {
    +      return pathStr.substring(0, dot) + "-" + uuid + pathStr.substring(dot);
    +    } else {
    +      return pathStr + "-" + uuid;
    +    }
    +  }
    +
    +  /**
    +   * Get the parent path of a string path: everything up to but excluding
    +   * the last "/" in the path.
    +   * @param pathStr path as a string
    +   * @return the parent or null if there is no parent.
    +   */
    +  public static String getParent(String pathStr) {
    +    int lastSlash = pathStr.lastIndexOf('/');
    +    if (lastSlash >= 0) {
    +      return pathStr.substring(0, lastSlash);
    +    }
    +    return null;
    +  }
    +
    +  /**
    +   * Using {@code URI#relativize()}, build the relative path from the
    +   * base path to the full path.
    +   * If {@code childPath} is not a child of {@code basePath} the outcome
    +   * os undefined.
    +   * @param basePath base path
    +   * @param childPath full path under the base path.
    +   * @return the relative path
    +   */
    +  public static String getRelativePath(Path basePath,
    +      Path childPath) {
    +    //
    +    // Use URI.create(Path#toString) to avoid URI character escape bugs
    +    URI relative = URI.create(basePath.toString())
    +        .relativize(URI.create(childPath.toString()));
    +    return relative.getPath();
    +  }
    +
    +
    +  /**
    +   * Varags constructor of paths. Not very efficient.
    +   * @param parent parent path
    +   * @param child child entries. "" elements are skipped.
    +   * @return the full child path.
    +   */
    +  public static Path path(Path parent, String... child) {
    +    Path p = parent;
    +    for (String c : child) {
    +      if (!c.isEmpty()) {
    +        p = new Path(p, c);
    +      }
    +    }
    +    return p;
    +  }
    +
    +  /**
    +   * Get the task attempt temporary directory in the local filesystem.
    +   * @param conf configuration
    +   * @param uuid some UUID, such as a job UUID
    +   * @param attempt attempt ID
    +   * @return a local task attempt directory.
    +   * @throws IOException IO problem.
    +   */
    +  public static Path getLocalTaskAttemptTempDir(Configuration conf,
    +      String uuid, TaskAttemptID attempt) throws IOException {
    +    int taskId = attempt.getTaskID().getId();
    +    int attemptId = attempt.getId();
    +    return path(localTemp(conf, taskId, attemptId),
    +        uuid,
    +        Integer.toString(getAppAttemptId(conf)),
    +        attempt.toString());
    +  }
    +
    +  /**
    +   * Try to come up with a good temp directory for different filesystems.
    +   * @param fs filesystem
    +   * @param conf configuration
    +   * @return a path under which temporary work can go.
    +   */
    +  public static Path tempDirForStaging(FileSystem fs,
    +      Configuration conf) {
    +    Path temp;
    +    switch (fs.getScheme()) {
    +    case "file":
    +      temp = fs.makeQualified(
    +          new Path(System.getProperty(JAVA_IO_TMPDIR)));
    +      break;
    +
    +    case "s3a":
    +      // the Staging committer may reject this if it doesn't believe S3A
    +      // is consistent.
    +      temp = fs.makeQualified(new Path(FILESYSTEM_TEMP_PATH));
    +      break;
    +
    +    // here assume that /tmp is valid
    +    case "hdfs":
    +    default:
    +      String pathname = conf.getTrimmed(
    +          FS_S3A_COMMITTER_STAGING_TMP_PATH, FILESYSTEM_TEMP_PATH);
    +      temp = fs.makeQualified(new Path(pathname));
    +    }
    +    return temp;
    +  }
    +
    +  /**
    +   * Get the Application Attempt ID for this job.
    +   * @param conf the config to look in
    +   * @return the Application Attempt ID for a given job.
    +   */
    +  private static int getAppAttemptId(Configuration conf) {
    +    return conf.getInt(
    +        MRJobConfig.APPLICATION_ATTEMPT_ID, 0);
    +  }
    +
    +  /**
    +   * Build a temporary path for the multipart upload commit information
    +   * in the supplied filesystem (which is expected to be the cluster FS)
    +   * @param conf configuration defining default FS.
    +   * @param uuid uuid of job
    +   * @return a path which can be used for temporary work
    +   * @throws IOException on an IO failure.
    +   */
    +  public static Path getMultipartUploadCommitsDirectory(Configuration conf,
    +      String uuid) throws IOException {
    +    FileSystem fs = FileSystem.get(conf);
    +    return getMultipartUploadCommitsDirectory(fs, conf, uuid);
    +  }
    +
    +  /**
    +   * Build a temporary path for the multipart upload commit information
    +   * in the supplied filesystem (which is expected to be the cluster FS)
    +   * @param fs target FS
    +   * @param conf configuration
    +   * @param uuid uuid of job
    +   * @return a path which can be used for temporary work
    +   * @throws IOException on an IO failure.
    +   */
    +  static Path getMultipartUploadCommitsDirectory(FileSystem fs,
    +      Configuration conf, String uuid) throws IOException {
    +    return path(tempDirForStaging(fs, conf),
    +        UserGroupInformation.getCurrentUser().getShortUserName(),
    +        uuid,
    +        STAGING_UPLOADS);
    +  }
    +
    +  // TODO: verify this is correct, it comes from dse-storage
    +  private static Path localTemp(Configuration conf, int taskId, int attemptId)
    +      throws IOException {
    +    String[] dirs = conf.getTrimmedStrings(BUFFER_DIR);
    +    Random rand = new Random(Objects.hashCode(taskId, attemptId));
    +    String dir = dirs[rand.nextInt(dirs.length)];
    +
    +    return FileSystem.getLocal(conf).makeQualified(new Path(dir));
    +  }
    +
    +  /**
    +   * Returns the partition of a relative file path, or null if the path is a
    +   * file name with no relative directory.
    +   *
    +   * @param relative a relative file path
    +   * @return the partition of the relative file path
    +   */
    +  protected static String getPartition(String relative) {
    +    return getParent(relative);
    +  }
    +
    +  /**
    +   * Get the set of partitions from the list of files being staged.
    +   * This is all immediate parents of those files. If a file is in the root
    +   * dir, the partition is declared to be
    +   * {@link StagingCommitterConstants#TABLE_ROOT}.
    +   * @param attemptPath path for the attempt
    +   * @param taskOutput list of output files.
    +   * @return list of partitions.
    +   * @throws IOException IO failure
    +   */
    +  public static Set<String> getPartitions(Path attemptPath,
    +      List<FileStatus> taskOutput)
    +      throws IOException {
    +    // get a list of partition directories
    +    Set<String> partitions = Sets.newLinkedHashSet();
    +    for (FileStatus fileStatus : taskOutput) {
    +      // sanity check the output paths
    +      Path outputFile = fileStatus.getPath();
    +      if (!fileStatus.isFile()) {
    +        throw new PathIsDirectoryException(outputFile.toString());
    +      }
    +      String partition = getPartition(
    +          getRelativePath(attemptPath, outputFile));
    +      partitions.add(partition != null ? partition : TABLE_ROOT);
    +    }
    +
    +    return partitions;
    +  }
    +
    +  /**
    +   * path filter.
    +   */
    +  static final class HiddenPathFilter implements PathFilter {
    --- End diff --
    
    its ubiquitous, isn't it? And in java 8, we can reimplement as a closure...


> Merge S3A committers into trunk
> -------------------------------
>
>                 Key: HADOOP-14971
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14971
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.0.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>
> Merge the HADOOP-13786 committer into trunk. This branch is being set up as a github PR for review there & to keep it out the mailboxes of the watchers on the main JIRA


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org