Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 18 Oct 2017 20:41:00 +0000 (UTC)
From: "John Zhuge (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13109789.1508185651000.1328.1508359260125@Atlassian.JIRA>
In-Reply-To: <JIRA.13109789.1508185651000@Atlassian.JIRA>
References: <JIRA.13109789.1508185651000@Atlassian.JIRA> <JIRA.13109789.1508185651355@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HADOOP-14954) MetricsSystemImpl#init should
 increment refCount when already initialized
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 18 Oct 2017 20:41:06 -0000


     [ https://issues.apache.org/jira/browse/HADOOP-14954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Zhuge updated HADOOP-14954:
--------------------------------
    Attachment: HADOOP-14954.002a.patch

Patch 002a
* This is 002 + HADOOP-14816.05

> MetricsSystemImpl#init should increment refCount when already initialized
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-14954
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14954
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.7.0
>            Reporter: John Zhuge
>            Priority: Minor
>         Attachments: HADOOP-14954.001.patch, HADOOP-14954.002.patch, HADOOP-14954.002a.patch
>
>
> {{++refCount}} here in {{init}} should be symmetric to {{--refCount}} in {{shutdown}}.
> {code:java}
>   public synchronized MetricsSystem init(String prefix) {
>     if (monitoring && !DefaultMetricsSystem.inMiniClusterMode()) {
>       LOG.warn(this.prefix +" metrics system already initialized!");
>       return this;
>     }
>     this.prefix = checkNotNull(prefix, "prefix");
>     ++refCount;
> {code}
> Move {{++refCount}}  to the beginning of this method.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org