Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3131F200D19 for ; Fri, 6 Oct 2017 13:42:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2FC46160BDB; Fri, 6 Oct 2017 11:42:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 74E1D1609D0 for ; Fri, 6 Oct 2017 13:42:04 +0200 (CEST) Received: (qmail 46722 invoked by uid 500); 6 Oct 2017 11:42:03 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 46711 invoked by uid 99); 6 Oct 2017 11:42:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Oct 2017 11:42:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 807EFCDB1B for ; Fri, 6 Oct 2017 11:42:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 17AUIxzrXwzI for ; Fri, 6 Oct 2017 11:42:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 869D85FB57 for ; Fri, 6 Oct 2017 11:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1DA04E0EF0 for ; Fri, 6 Oct 2017 11:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C78292416D for ; Fri, 6 Oct 2017 11:42:00 +0000 (UTC) Date: Fri, 6 Oct 2017 11:42:00 +0000 (UTC) From: "Kannapiran Srinivasan (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-14899) Restrict Access to setPermission operation when authorization is enabled in WASB MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 06 Oct 2017 11:42:05 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14899?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 194481#comment-16194481 ]=20 Kannapiran Srinivasan commented on HADOOP-14899: ------------------------------------------------ [~stevel@apache.org] : I have updated the patch with following fixes * L698: I think it is better to have a separate list defined for chmod allo= wed users instead of using a common one for both chown and chmod. Because t= his gives a flexibility to configure different set of allowed users for bot= h chmod & chown. I have reverted the code back to use fs.azure.chown.allowe= d.userlist for chown. * L2916: Fixed * L2980: Fixed * L7971. chmod & chown should check against the current user not the actual= User. actualUser is set in the context of impersonation. Earlier logic on s= etPermission was wrongly checking the actualUser instead of currentUser. Ye= s getCurrentUser should not be null during chmod / chown calls irrespective= of impersonation enabled or not * L3055. Cached the user lists (chown, chmod & daemon) during the init & en= abled set of helper methods for tests to update them during test runs * Refactoring is done on the testcases as mentioned in the comment=C2=A0 Apart from this I have fixed testcases related to setOwner (testSetOwnerThr= owsForUnauthorisedUsers, testSetOwnerFailsForIllegalSetup, testSetOwnerThro= wsForUnauthorisedUsers & testSetOwnerSucceedsForAnyUserWhenWildCardIsSpecif= ied) All the tests have passed in hadoop-azure in both secure and unsecure mode.= Tested against storage account in South India > Restrict Access to setPermission operation when authorization is enabled = in WASB > -------------------------------------------------------------------------= ------- > > Key: HADOOP-14899 > URL: https://issues.apache.org/jira/browse/HADOOP-14899 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure > Reporter: Kannapiran Srinivasan > Assignee: Kannapiran Srinivasan > Labels: fs, secure, wasb > Attachments: HADOOP-14899-001.patch, HADOOP-14899-002.patch, HADO= OP-14899-003.patch, HADOOP-14899-004.patch > > > In case of authorization enabled Wasb clusters, we need to restrict setti= ng permissions on files or folders to owner or list of privileged users. > Currently in the WASB implementation even when authorization is enabled t= here is no check happens while doing setPermission call. In this JIRA we wo= uld like to add the check on the setPermission call in NativeAzureFileSyste= m implementation so that only owner or the privileged list of users or daem= on users can change the permissions of files/folders -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org