Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 13 Oct 2017 16:10:00 +0000 (UTC)
From: "Andras Bokor (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13050446.1489400125000.5101.1507911000407@Atlassian.JIRA>
In-Reply-To: <JIRA.13050446.1489400125000@Atlassian.JIRA>
References: <JIRA.13050446.1489400125000@Atlassian.JIRA> <JIRA.13050446.1489400125967@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HADOOP-14178) Move Mockito up to version 2.x
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 13 Oct 2017 16:10:04 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203764#comment-16203764 ] 

Andras Bokor commented on HADOOP-14178:
---------------------------------------

[~ajisakaa],
I found only some very minor thing:
# Declaration of InfoWithSameName class is now longer than 80 chars (it was 79 before the patch)
# InfoWithSameName: {{return expected.equals((info).name());}} brackets around info seem unnecessary

Otherwise looks good.

> Move Mockito up to version 2.x
> ------------------------------
>
>                 Key: HADOOP-14178
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14178
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 2.9.0
>            Reporter: Steve Loughran
>            Assignee: Akira Ajisaka
>         Attachments: HADOOP-14178.001.patch
>
>
> I don't know when Hadoop picked up Mockito, but it has been frozen at 1.8.5 since the switch to maven in 2011. 
> Mockito is now at version 2.1, [with lots of Java 8 support|https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2]. That' s not just defining actions as closures, but in supporting Optional types, mocking methods in interfaces, etc. 
> It's only used for testing, and, *provided there aren't regressions*, cost of upgrade is low. The good news: test tools usually come with good test coverage. The bad: mockito does go deep into java bytecodes.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org