hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14971) Merge S3A committers into trunk
Date Thu, 26 Oct 2017 19:11:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221040#comment-16221040

ASF GitHub Bot commented on HADOOP-14971:

Github user steveloughran commented on a diff in the pull request:

    --- Diff: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
    @@ -1269,6 +1500,8 @@ PutObjectResult putObjectDirect(PutObjectRequest putObjectRequest)
         try {
           PutObjectResult result = s3.putObject(putObjectRequest);
           incrementPutCompletedStatistics(true, len);
    +      // update metadata
    +      finishedWrite(putObjectRequest.getKey(), len);
    --- End diff --
    oh we did, it just got moved around. It's what updates s3guard. Critical it's there. What
has probably just changed is where it gets invoked from. Before it was part of innerCopyFromLocalFile(),
but that's had the inner put pulled out into executePut(), which is how the magic committers
can PUT its summary data up directly into the __magic dirs

> Merge S3A committers into trunk
> -------------------------------
>                 Key: HADOOP-14971
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14971
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.0.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
> Merge the HADOOP-13786 committer into trunk. This branch is being set up as a github
PR for review there & to keep it out the mailboxes of the watchers on the main JIRA

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message