hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14929) Cleanup usage of decodecomponent and use QueryStringDecoder from netty
Date Thu, 26 Oct 2017 23:33:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221451#comment-16221451

Arpit Agarwal commented on HADOOP-14929:

Thanks [~bharatviswa]. The patch LGTM.

Can you please add a couple of more test cases e.g. for
# createflag=create,overwrite
# createflag=

And maybe a couple of negative test cases for invalid flags, like:
# createflag=,
# createflag=create,

To make sure the behavior does not change.

> Cleanup usage of decodecomponent and use QueryStringDecoder from netty
> ----------------------------------------------------------------------
>                 Key: HADOOP-14929
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14929
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>         Attachments: HADOOP-14929.00.patch, HADOOP-14929.01.patch
> This is from the review of HADOOP-14910
> There is also other place usage of decodeComponent(param(CreateFlagParam.NAME), StandardCharsets.UTF_8);
> In ParameterParser.java Line 147-148:
> String cf = decodeComponent(param(CreateFlagParam.NAME), StandardCharsets.UTF_8);
> Use QueryStringDecoder from netty here too and cleanup the decodeComponent. Actually
this is added for netty issue only.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message