hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14918) remove the Local Dynamo DB test option
Date Tue, 03 Oct 2017 02:36:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189188#comment-16189188
] 

Aaron Fabbri commented on HADOOP-14918:
---------------------------------------

The local dynamo lib was useful during development I think, but now I'm in favor of removing
it.  I typically test local (i.e. -Ddynamo *not* specified) and live dynamo.  As we've seen,
live dynamo behaves differently so we end up having to test it anyways.

I think you still want -Ddynamo flag to choose LocalMetadataStore test case, no?  Having the
local MetadataStore available helps make the case for removing localdynamo, IMO.  We get some
coverage without requiring live dynamo at least.




> remove the Local Dynamo DB test option
> --------------------------------------
>
>                 Key: HADOOP-14918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14918
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.0.0
>            Reporter: Steve Loughran
>
> I'm going to propose cutting out the localdynamo test option for s3guard
> * the local DDB JAR is unmaintained/lags the SDK We work with...eventually there'll be
differences in API.
> * as the local dynamo DB is unshaded. it complicates classpath setup for the build. Remove
it and there's no need to worry about versions of anything other than the shaded AWS
> * it complicates test runs. Now we need to test for both localdynamo *and* real dynamo
> * but we can't ignore real dynamo, because that's the one which matters
> While the local option promises to reduce test costs, really, it's just adding complexity.
If you are testing with s3guard, you need to have a real table to test against., And with
the exception of those people testing s3a against non-AWS, consistent endpoints, everyone
should be testing with S3Guard.
> Straightforward to remove.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message