hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-14872) CryptoInputStream should implement unbuffer
Date Fri, 06 Oct 2017 19:36:01 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

John Zhuge updated HADOOP-14872:
    Attachment: HADOOP-14872.010.patch

Patch 010
* Enhance CryptoStreamsTestBase.testUnbuffer to test both buffered read and pread
* Remove prefix "CAP_" from constant capability strings upon [~eddyxu]'s good suggestion.
Unfortunately BlockBlobAppendStream.java and DFSOutputStream.java have to be updated.
* CryptoInputStream.unbuffer cleans buffer pool and descriptor pool (for preads), but leave
inBuffer/outBuffer/descryptor (for buffered read) alone to avoid too much change. Trying to
make this patch smaller. If desired, we can file a follow-up JIRA for unbuffer to release
these buffers.
* Verified javadoc for StreamCapabilities and its constant capability strings. [~eddyxu] please
confirm it fixes HDFS-12604.

> CryptoInputStream should implement unbuffer
> -------------------------------------------
>                 Key: HADOOP-14872
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14872
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 2.6.4
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>         Attachments: HADOOP-14872.001.patch, HADOOP-14872.002.patch, HADOOP-14872.003.patch,
HADOOP-14872.004.patch, HADOOP-14872.005.patch, HADOOP-14872.006.patch, HADOOP-14872.007.patch,
HADOOP-14872.008.patch, HADOOP-14872.009.patch, HADOOP-14872.010.patch
> Discovered in IMPALA-5909.
> Opening an encrypted HDFS file returns a chain of wrapped input streams:
> {noformat}
> HdfsDataInputStream
>   CryptoInputStream
>     DFSInputStream
> {noformat}
> If an application such as Impala or HBase calls HdfsDataInputStream#unbuffer, FSDataInputStream#unbuffer
will be called:
> {code:java}
>     try {
>       ((CanUnbuffer)in).unbuffer();
>     } catch (ClassCastException e) {
>       throw new UnsupportedOperationException("this stream does not " +
>           "support unbuffering.");
>     }
> {code}
> If the {{in}} class does not implement CanUnbuffer, UOE will be thrown. If the application
is not careful, tons of UOEs will show up in logs.
> In comparison, opening an non-encrypted HDFS file returns this chain:
> {noformat}
> HdfsDataInputStream
>   DFSInputStream
> {noformat}
> DFSInputStream implements CanUnbuffer.
> It is good for CryptoInputStream to implement CanUnbuffer for 2 reasons:
> * Release buffer, cache, or any other resource when instructed
> * Able to call its wrapped DFSInputStream unbuffer
> * Avoid the UOE described above. Applications may not handle the UOE very well.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message