hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14217) Object Storage: support colon in object path
Date Thu, 12 Oct 2017 23:47:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202820#comment-16202820
] 

ASF GitHub Bot commented on HADOOP-14217:
-----------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/269#discussion_r144437556
  
    --- Diff: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
---
    @@ -214,6 +213,12 @@ public Path(String pathString) throws IllegalArgumentException {
         // uri path is the rest of the string -- query & fragment not supported
         String path = pathString.substring(start, pathString.length());
     
    +    // add "./" in front of Linux relative paths so that a path containing
    +    // a colon e.q. "a:b" will not be interpreted as scheme "a".
    +    if (!WINDOWS && !path.isEmpty() && path.charAt(0) != '/') {
    --- End diff --
    
    To avoid String concatenation and creation of unnecessary String objects. Prior to the
patch, there was no "./" in case of a long path and it can (should?) be avoided with the patch
if that long path does not contain ":".
    I am not a committer for Hadoop and it is a recommendation to consider only.


> Object Storage: support colon in object path
> --------------------------------------------
>
>                 Key: HADOOP-14217
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14217
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, fs/oss
>    Affects Versions: 2.8.1
>            Reporter: Genmao Yu
>            Assignee: Yuliya Feldman
>         Attachments: Colon handling in hadoop Path.pdf
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message