hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14217) Object Storage: support colon in object path
Date Thu, 12 Oct 2017 16:36:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202239#comment-16202239
] 

ASF GitHub Bot commented on HADOOP-14217:
-----------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/269#discussion_r144343525
  
    --- Diff: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
---
    @@ -196,8 +196,7 @@ public Path(String pathString) throws IllegalArgumentException {
         // parse uri scheme, if any
         int colon = pathString.indexOf(':');
         int slash = pathString.indexOf('/');
    -    if ((colon != -1) &&
    -        ((slash == -1) || (colon < slash))) {     // has a scheme
    +    if ((colon != -1) && (colon == (slash-1))) {     // has a scheme
    --- End diff --
    
    @yufeldman In the first case, you merge absolute and relative path, in the second case,
there is an attempt to merge two absolute path, should they be handled differently if merging
two absolute path should be allowed at all?


> Object Storage: support colon in object path
> --------------------------------------------
>
>                 Key: HADOOP-14217
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14217
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, fs/oss
>    Affects Versions: 2.8.1
>            Reporter: Genmao Yu
>            Assignee: Yuliya Feldman
>         Attachments: Colon handling in hadoop Path.pdf
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message