hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lei (Eddy) Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13055) Implement linkMergeSlash for ViewFileSystem
Date Mon, 02 Oct 2017 23:59:01 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189080#comment-16189080
] 

Lei (Eddy) Xu commented on HADOOP-13055:
----------------------------------------

Thanks for updates, [~manojg]. Great work.

* Should we consider move the "fallback link" from {{INodeDir}}to {{InodeTree}}, as conceptually
it is at most 1 per tree / root. It can simplify code a bit by removing many precondition
checks. For example, it can eliminate {{isRoot}} AND {{hasFallbackLink}} checks from INodeDir.
* Could you rephrase the doc about the concept of {{internalDir}}. 
* Is {{INodeDir#resolve()}} called? Can we remove it?
* Please add comments for {{static class LinkEntry }}
* for {{INodeDir#getChildren}} you might want to return a unmodified map. 
* It'd be nice to raise a user readable error if mutliple MERGE_SLASH or SINGLE_FALLBACK were
configured.
* Maybe check {{mergeSlashTarget == null}} ?
{code}
if (linkType != LinkType.MERGE_SLASH) {
..
} else {
  ...
  mergeSlashTarget = target;
}
{code}
* Test cases are awesome !

> Implement linkMergeSlash for ViewFileSystem
> -------------------------------------------
>
>                 Key: HADOOP-13055
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13055
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs, viewfs
>    Affects Versions: 2.7.5
>            Reporter: Zhe Zhang
>            Assignee: Manoj Govindassamy
>         Attachments: HADOOP-13055.00.patch, HADOOP-13055.01.patch, HADOOP-13055.02.patch,
HADOOP-13055.03.patch, HADOOP-13055.04.patch, HADOOP-13055.05.patch, HADOOP-13055.06.patch,
HADOOP-13055.07.patch, HADOOP-13055.08.patch
>
>
> In a multi-cluster environment it is sometimes useful to operate on the root / slash
directory of an HDFS cluster. E.g., list all top level directories. Quoting the comment in
{{ViewFs}}:
> {code}
>  *   A special case of the merge mount is where mount table's root is merged
>  *   with the root (slash) of another file system:
>  *   <ul>
>  *   <li>    fs.viewfs.mounttable.default.linkMergeSlash=hdfs://nn99/
>  *   </ul>
>  *   In this cases the root of the mount table is merged with the root of
>  *            <b>hdfs://nn99/ </b> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message