Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 22 Sep 2017 17:47:00 +0000 (UTC)
From: "Thomas Marquardt (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13094378.1502684141000.178233.1506102420416@Atlassian.JIRA>
In-Reply-To: <JIRA.13094378.1502684141000@Atlassian.JIRA>
References: <JIRA.13094378.1502684141000@Atlassian.JIRA> <JIRA.13094378.1502684141578@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HADOOP-14768) Honoring sticky bit during
 Deletion when authorization is enabled in WASB
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 22 Sep 2017 17:47:06 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176798#comment-16176798 ] 

Thomas Marquardt commented on HADOOP-14768:
-------------------------------------------

I opened HADOOP-14768.005.patch and still see major changes to {{NativeAzureFileSystem.delete}}.  

The point of my earlier feedback is that we should minimize risk for medium to high risk changes that are going to be ported to branch-2.  We can do this by using config to enable the new functionality without a significant impact to existing functionality.

What I had in mind is that you would leave the current delete code as-is and add a new delete method for the case when authorization is enabled:

{code:java}

public boolean delete(...) throws IOException {
  if (azureAuthorization) {
    return deleteWithAuthEnabled(...);
  }
  // current delete code goes here
}

private boolean deleteWithAuthEnabled(...) throws IOException {
  // new delete code for the case when authorization is enabled goes here
}
{code}


> Honoring sticky bit during Deletion when authorization is enabled in WASB
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-14768
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14768
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>            Reporter: Varada Hemeswari
>            Assignee: Varada Hemeswari
>              Labels: fs, secure, wasb
>         Attachments: HADOOP-14768.001.patch, HADOOP-14768.002.patch, HADOOP-14768.003.patch, HADOOP-14768.003.patch, HADOOP-14768.004.patch, HADOOP-14768.004.patch, HADOOP-14768.005.patch
>
>
> When authorization is enabled in WASB filesystem, there is a need for stickybit in cases where multiple users can create files under a shared directory. This additional check for sticky bit is reqired since any user can delete another user's file because the parent has WRITE permission for all users.
> The purpose of this jira is to implement sticky bit equivalent for 'delete' call when authorization is enabled.
> Note : Sticky bit implementation for 'Rename' operation is not done as part of this JIRA


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org