hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14851) LambdaTestUtils.eventually() doesn't spin on Assertion failures
Date Sat, 09 Sep 2017 03:46:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159708#comment-16159708
] 

Hudson commented on HADOOP-14851:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12829 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12829/])
HADOOP-14851 LambdaTestUtils.eventually() doesn't spin on Assertion (fabbri: rev 180e814b081d3707c95641171d649b547db41a04)
* (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/LambdaTestUtils.java
* (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TestLambdaTestUtils.java


> LambdaTestUtils.eventually() doesn't spin on Assertion failures
> ---------------------------------------------------------------
>
>                 Key: HADOOP-14851
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14851
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.8.1
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>             Fix For: 3.0.0-beta1
>
>         Attachments: HADOOP-14851-001.patch, HADOOP-14851-002.patch, HADOOP-14851-003.patch
>
>
> This is funny. The {{LsmbdaTestUtils.eventually()}} method, meant to spin until a closure
stops raising exceptions, doesn't catch {{Error}} and subclasses, so doesn't fail on an {{Assert.assert()}}
failure, which raises an {{AssertionError}}. My bad :)
> Example:
> {code}
>     eventually(TIMEOUT,
>         () -> {
>           while (counter.incrementAndGet()  < 5) {
>             assert false : "oops";
>           }
>         },
>         retryLogic);
> {code}
> Fix: catch Throwable, rethrow. Needs to add VirtualMachineError & subclasses to the
set of errors not to spin on (OOM, stack overflow, ...)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message