hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14843) FsPermission symbolic parsing failed to detect invalid argument
Date Fri, 08 Sep 2017 15:24:01 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158788#comment-16158788
] 

Jason Lowe commented on HADOOP-14843:
-------------------------------------

Thanks for updating the patch!  Looks good overall, just a readability nit for these two lines:
{code}
    assertEquals(950, new FsPermission("+rwrt").toShort());
[...]
    assertEquals(1023, new FsPermission("+rwxt").toShort());
{code}

It would be easier to read using the octal notation for the integer constants as was done
in the other toShort tests above this.

> FsPermission symbolic parsing failed to detect invalid argument
> ---------------------------------------------------------------
>
>                 Key: HADOOP-14843
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14843
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.7.4, 2.8.1
>            Reporter: Jason Lowe
>            Assignee: Bharat Viswanadham
>         Attachments: HADOOP-14843.01.patch, HADOOP-14843.02.patch, HADOOP-14843.03.patch,
HADOOP-14843.patch
>
>
> A user misunderstood the syntax format for the FsPermission symbolic constructor and
passed the argument "-rwr" instead of "u=rw,g=r".  In 2.7 and earlier this was silently misinterpreted
as mode 0777 and in 2.8 it oddly became mode 0000.  In either case FsPermission should have
flagged "-rwr" as an invalid argument rather than silently misinterpreting it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message