hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14843) FsPermission symbolic parsing failed to detect invalid argument
Date Thu, 07 Sep 2017 19:24:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157477#comment-16157477

Jason Lowe commented on HADOOP-14843:

Thanks for the patch!  I'd rather see checks against the full mode bits, like:
  assertEquals(0444, new FsPermission("+r").toShort());

rather than the explicit perm bit checking.  The problem with the latter is that FsPermission("+r")
could act like mode 0777 and still pass the tests as they are written in this patch.  Doing
a check against the integer value means we're also testing the bits that should _not_ be set.

> FsPermission symbolic parsing failed to detect invalid argument
> ---------------------------------------------------------------
>                 Key: HADOOP-14843
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14843
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.7.4, 2.8.1
>            Reporter: Jason Lowe
>            Assignee: Bharat Viswanadham
>         Attachments: HADOOP-14843.01.patch, HADOOP-14843.patch
> A user misunderstood the syntax format for the FsPermission symbolic constructor and
passed the argument "-rwr" instead of "u=rw,g=r".  In 2.7 and earlier this was silently misinterpreted
as mode 0777 and in 2.8 it oddly became mode 0000.  In either case FsPermission should have
flagged "-rwr" as an invalid argument rather than silently misinterpreting it.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message