hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanisha Koneru (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14827) Allow StopWatch to accept a Timer parameter for tests
Date Wed, 06 Sep 2017 17:43:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155769#comment-16155769
] 

Hanisha Koneru commented on HADOOP-14827:
-----------------------------------------

Thanks for the improvement, [~xkrogen]. 
The patch LGTM. TestZKFailoverController and TestShellBasedUnixGroupsMapping pass locally
for me too.
+1 (non-binding).

> Allow StopWatch to accept a Timer parameter for tests
> -----------------------------------------------------
>
>                 Key: HADOOP-14827
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14827
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common, test
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Minor
>         Attachments: HADOOP-14827.000.patch
>
>
> {{StopWatch}} should optionally accept a {{Timer}} parameter rather than directly using
{{Time}} so that its behavior can be controlled during tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message