hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
Date Fri, 15 Sep 2017 21:03:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168517#comment-16168517

Wangda Tan commented on HADOOP-14670:

[~aw], we just saw issue of building trunk includes this patch has compilation issue. (succeeded
in centos 7 but failed in centos 7).

According to https://cmake.org/cmake/help/v3.0/command/cmake_minimum_required.html, FATAL
parameter ignored by cmake with newer version.

Failure message looks like: 

[WARNING] .../hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/modules/gpu/gpu-module.c:107:
error: ‘for’ loop initial declarations are only allowed in C99 mode

It looks like we need to either find a better way to fail build with lower versioned cmake,
or we need to add set C99 macros back.

> Increase minimum cmake version for all platforms
> ------------------------------------------------
>                 Key: HADOOP-14670
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14670
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0-beta1
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>             Fix For: 3.0.0-beta1
>         Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, HADOOP-14670.02.patch,
> cmake 2.6 is old at this point and I'd be greatly surprised if anyone is actually using
it or testing against it.  It's probably time to upgrade to something approaching modern.
> * Mac OS X already requires 3.0
> * If HADOOP-14667 gets committed, Windows bumps to 3.1
> * There is special handling in at least one CMakeLists.txt for versions less than 3.1
> Given the last two points, I'd propose making the minimum 3.1, if not something higher
due to  compiler support for newer compilers across all platforms.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message