hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-14414) Calling maven-site-plugin directly for docs profile is unnecessary
Date Fri, 01 Sep 2017 15:41:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Allen Wittenauer updated HADOOP-14414:
--------------------------------------
       Resolution: Fixed
    Fix Version/s: 3.0.0-beta1
           Status: Resolved  (was: Patch Available)

+1 committing to trunk.

Thanks for the contribution!

> Calling maven-site-plugin directly for docs profile is unnecessary
> ------------------------------------------------------------------
>
>                 Key: HADOOP-14414
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14414
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Andras Bokor
>            Assignee: Andras Bokor
>            Priority: Minor
>             Fix For: 3.0.0-beta1
>
>         Attachments: HADOOP-14414.01.patch, HADOOP-14414.02.patch, missingFiles
>
>
> For a few modules:
> * hadoop-auth
> * hadoop-kms
> * hadoop-hdfs-httpfs
> * hadoop-sls
> we call {{mave-site-plugin}} directly when docs profile is active.
> In main pom we use {{excludeDefaults}} in reporting section and allow only javadoc and
dependency-plugin for the report. Since javadoc plugin is set to {{inherited}} false it won't
be called on individual child modules. So actually {{maven-dependency-plugin:analyze-report}}
is the only additional goal which will run.
> I debugged the process with {{mvn clean package -DskipTests -Dmaven.javadoc.skip=true
-DskipShade -Pdocs -X}} command and in all the 4 affected modules I found the following configuration
for site plugin:
> {code}<reportPlugins>
>     <reportPlugin>
>       <groupId>org.apache.maven.plugins</groupId>
>       <artifactId>maven-dependency-plugin</artifactId>
>       <version>2.10</version>
>       <reportSets>
>         <reportSet>
>           <id>default</id>
>           <reports>
>             <report>analyze-report</report>
>           </reports>
>         </reportSet>
>       </reportSets>
>     </reportPlugin>
>   </reportPlugins>{code}
> At this point I do not see the purpose of calling {{mave-site-plugin}} for docs profile.
It does not contain useful information. Or if it does why don't we call for other modules?
It's inconsistent.
> Considering to remove.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message