hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-14089) Automated checking for malformed client artifacts.
Date Tue, 12 Sep 2017 23:40:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sean Busbey updated HADOOP-14089:
---------------------------------
    Attachment: HADOOP-14089.2.patch

-2 ready for review

 - rebase to recent trunk
 - squash
 - includes latest patch for HADOOP-14857
 - fixes relocation to be consistent across all three artifacts so the resultant jars work
together in the IT.

dependency reduced poms look reasonable. the minicluster one has some additional optional
dependencies that are surprising, but since they're optional, and thus won't be see by downstream
folks, I think we're fine for now and can chase them down later.

{code}
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Hadoop Client API 3.1.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:3.0.1:tree (default-cli) @ hadoop-client-api ---
[INFO] org.apache.hadoop:hadoop-client-api:jar:3.1.0-SNAPSHOT
{code}

{code}
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Hadoop Client Runtime 3.1.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:3.0.1:tree (default-cli) @ hadoop-client-runtime ---
[INFO] org.apache.hadoop:hadoop-client-runtime:jar:3.1.0-SNAPSHOT
[INFO] +- org.apache.hadoop:hadoop-client-api:jar:3.1.0-SNAPSHOT:runtime
[INFO] +- org.apache.htrace:htrace-core4:jar:4.1.0-incubating:runtime
[INFO] +- org.slf4j:slf4j-api:jar:1.7.25:runtime
[INFO] +- commons-logging:commons-logging:jar:1.1.3:runtime
[INFO] +- com.google.code.findbugs:jsr305:jar:3.0.0:runtime
[INFO] \- log4j:log4j:jar:1.2.17:runtime (optional) 
{code}

{code}
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Hadoop Client Test Minicluster 3.1.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:3.0.1:tree (default-cli) @ hadoop-client-minicluster ---
[INFO] org.apache.hadoop:hadoop-client-minicluster:jar:3.1.0-SNAPSHOT
[INFO] +- org.apache.hadoop:hadoop-client-api:jar:3.1.0-SNAPSHOT:runtime
[INFO] +- org.apache.hadoop:hadoop-client-runtime:jar:3.1.0-SNAPSHOT:runtime
[INFO] |  +- org.apache.htrace:htrace-core4:jar:4.1.0-incubating:runtime
[INFO] |  +- org.slf4j:slf4j-api:jar:1.7.25:runtime
[INFO] |  +- commons-logging:commons-logging:jar:1.1.3:runtime
[INFO] |  \- com.google.code.findbugs:jsr305:jar:3.0.0:runtime
[INFO] +- junit:junit:jar:4.11:runtime 
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:runtime
[INFO] +- org.apache.hadoop:hadoop-annotations:jar:3.1.0-SNAPSHOT:compile (optional)
[INFO] +- org.apache.hadoop:hadoop-yarn-server-timelineservice:jar:3.1.0-SNAPSHOT:runtime
(optional)
[INFO] +- org.apache.hadoop:hadoop-common:test-jar:tests:3.1.0-SNAPSHOT:compile (optional)
[INFO] +- org.apache.hadoop:hadoop-hdfs:test-jar:tests:3.1.0-SNAPSHOT:compile (optional)
[INFO] \- org.apache.hadoop:hadoop-mapreduce-client-jobclient:test-jar:tests:3.1.0-SNAPSHOT:compile
(optional)
{code}

> Automated checking for malformed client artifacts.
> --------------------------------------------------
>
>                 Key: HADOOP-14089
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14089
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0-alpha2
>            Reporter: David Phillips
>            Assignee: Sean Busbey
>            Priority: Critical
>         Attachments: HADOOP-14089.2.patch, HADOOP-14089.WIP.0.patch, HADOOP-14089.WIP.1.patch
>
>
> The jar includes things like {{assets}}, {{okio}}, {{javax/annotation}}, {{javax/ws}},
{{mozilla}}, etc.
> An easy way to verify this is to look at the contents of the jar:
> {code}
> jar tf hadoop-client-runtime-xxx.jar | sort | grep -v '^org/apache/hadoop'
> {code}
> For standard dependencies, such as the JSR 305 {{javax.annotation}} or JAX-RS {{javax.ws}},
it makes sense for those to be normal dependencies in the POM -- they are standard, so version
conflicts shouldn't be a problem. The JSR 305 annotations can be {{<optional>true</optional>}}
since they aren't needed at runtime (this is what Guava does).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message