Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 30 Aug 2017 19:09:00 +0000 (UTC)
From: "Thomas Marquardt (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13098548.1504096922000.162903.1504120140403@Atlassian.JIRA>
In-Reply-To: <JIRA.13098548.1504096922000@Atlassian.JIRA>
References: <JIRA.13098548.1504096922000@Atlassian.JIRA> <JIRA.13098548.1504096922368@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HADOOP-14820)  Fix for HDFS semantics parity
 for mkdirs -p
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 30 Aug 2017 19:09:07 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-14820?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16=
147860#comment-16147860 ]=20

Thomas Marquardt commented on HADOOP-14820:
-------------------------------------------

Looks good.  I have the following feedback:

*NativeAzureFileSystem.java*
 *L1714* - When the file already exists and overwrite is true, both {{perfo=
rmAuthCheck}} calls (L1700 and L1714) are checking permissions on the file.=
  The {{performAuthCheck}} on L1714 can be removed.

 *L2426* - The method {{getAncestor}} no longer returns the ancestor or par=
ent path; instead, it returns the first path segment that exists.  I recomm=
end renaming it=20
{{getFirstPathSegmentThatExists}}.

 *L2459* - The {{ancestor}} field is actual the first path segment that exi=
sts, which may be the file itself. method {{getAncestor}} no longer returns=
 the ancestor or parent path; instead, it returns the first path segment th=
at exists.  I recommend renaming it {{firstExistingPathSegment}}.


.

>  Fix for HDFS semantics parity for mkdirs -p
> --------------------------------------------
>
>                 Key: HADOOP-14820
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14820
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/azure
>            Reporter: Sivaguru Sankaridurg
>            Assignee: Sivaguru Sankaridurg
>              Labels: azure, fs, secure, wasb
>         Attachments: HADOOP-14820.001.patch, HADOOP-14820.002.patch
>
>
> No authorization checks should be made when a user tries to create (mkdir=
s -p) an existing folder hierarchy.
> For example, if we start with _/home/hdiuser/prefix_ pre-created, and do =
the following operations, the results should be as shown below.
> {noformat}
> hdiuser@hn0-0d2f67:~$ sudo chown root:root prefix
> hdiuser@hn0-0d2f67:~$ sudo chmod 555 prefix
> hdiuser@hn0-0d2f67:~$ ls -l
> dr-xr-xr-x 3 root    root      4096 Aug 29 08:25 prefix
> hdiuser@hn0-0d2f67:~$ mkdir -p /home
> hdiuser@hn0-0d2f67:~$ mkdir -p /home/hdiuser
> hdiuser@hn0-0d2f67:~$ mkdir -p /home/hdiuser/prefix
> hdiuser@hn0-0d2f67:~$ mkdir -p /home/hdiuser/prefix/1
> mkdir: cannot create directory =C3=A2/home/hdiuser/prefix/1=C3=A2: Permis=
sion denied
> The first three mkdirs succeed, because the ancestor is already present. =
The fourth one fails because of a permission check against the (shorter) an=
cestor (as compared to the path being created).
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org