Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5C61120049E for ; Thu, 10 Aug 2017 19:11:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5B30E16BB2B; Thu, 10 Aug 2017 17:11:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A101E16BB33 for ; Thu, 10 Aug 2017 19:11:03 +0200 (CEST) Received: (qmail 60153 invoked by uid 500); 10 Aug 2017 17:11:02 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 60137 invoked by uid 99); 10 Aug 2017 17:11:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Aug 2017 17:11:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4FFAD1807DD for ; Thu, 10 Aug 2017 17:11:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id N58kV_34n2nk for ; Thu, 10 Aug 2017 17:11:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0D6675F569 for ; Thu, 10 Aug 2017 17:11:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 60E99E04F7 for ; Thu, 10 Aug 2017 17:11:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1A25024161 for ; Thu, 10 Aug 2017 17:11:00 +0000 (UTC) Date: Thu, 10 Aug 2017 17:11:00 +0000 (UTC) From: "Wei-Chiu Chuang (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-14743) CompositeGroupsMapping should not swallow exceptions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 10 Aug 2017 17:11:04 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-14743: ------------------------------------- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-beta1 2.9.0 Status: Resolved (was: Patch Available) Committed the last patch to trunk and branch-2. Thanks [~drankye] for reviewing it! > CompositeGroupsMapping should not swallow exceptions > ---------------------------------------------------- > > Key: HADOOP-14743 > URL: https://issues.apache.org/jira/browse/HADOOP-14743 > Project: Hadoop Common > Issue Type: Bug > Components: security > Affects Versions: 2.5.0 > Reporter: Wei-Chiu Chuang > Assignee: Wei-Chiu Chuang > Fix For: 2.9.0, 3.0.0-beta1 > > Attachments: HADOOP-14743.001.patch, HADOOP-14743.002.patch > > > {code:title=CompositeGroupsMapping#getGroups} > for (GroupMappingServiceProvider provider : providersList) { > try { > groups = provider.getGroups(user); > } catch (Exception e) { > //LOG.warn("Exception trying to get groups for user " + user, e); > } > if (groups != null && ! groups.isEmpty()) { > groupSet.addAll(groups); > if (!combined) break; > } > } > {code} > If anything fails inside the underlying groups mapping service provider, there's no way to tell what went wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org