hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rushabh S Shah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14814) Fix incompatible API change on FsServerDefaults to HADOOP-14104
Date Wed, 30 Aug 2017 13:40:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147247#comment-16147247

Rushabh S Shah commented on HADOOP-14814:

Thanks [~djp] for finding the bug.
Apologies for introducing the bug.
+1 non-binding. The patch lgtm.
Regarding the test failures:
1.  {{org.apache.hadoop.fs.sftp.TestSFTPFileSystem#testGetAccessTime}}: This failure is being
tracked by {{HADOOP-14206}}
Even though in HADOOP-14206, different test is failing but the stack trace is the same.

2. {{org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem#testTrashRoot}}
This test passes locally on my box. I think its a case of not cleaning up.

> Fix incompatible API change on FsServerDefaults to HADOOP-14104
> ---------------------------------------------------------------
>                 Key: HADOOP-14814
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14814
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Blocker
>         Attachments: HADOOP-14814.patch
> From recently jdiff report: https://builds.apache.org/job/Hadoop-2.8-JACC/376/artifact/target/compat-check/report.html.
We found an incompatible API change: in HADOOP-14104, we remove the constructor with replacing
with more parameters. This will cause API incompatible given FsServerDefaults marked as public.
> We should fix it before 2.8.2 and 3.0-beta kicked out.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message