hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-14749) review s3guard docs & code prior to merge
Date Tue, 08 Aug 2017 22:25:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119111#comment-16119111
] 

Steve Loughran edited comment on HADOOP-14749 at 8/8/17 10:24 PM:
------------------------------------------------------------------

Big review

* docs reviewed, edited. Added: per-bucket config example, security, more troubleshooting.
* moved section on testing into main testing.md file
* javadocs audited
* moved imports *on new files* into the project's preferred order.
* tuned the tests

Other than javadocs, imports and some layout, the only real code change in production is to
use a switch statement in {{S3AFileSystem.innerMkdirs()}}.


was (Author: stevel@apache.org):
Big review

* docs reviewed, edited. Added: per-bucket config example, security, more troubleshooting.
* moved section on testing into main testing.md file
* javadocs audited
* moved imports *on new files* into the project's preferred order.
* tuned the tests

Other than javadocs, imports and some layout, the only real code change in production is to
use a switch statement in {{S3AFileSystem.checkPathForDirectory()}}.

> review s3guard docs & code prior to merge
> -----------------------------------------
>
>                 Key: HADOOP-14749
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14749
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: documentation, fs/s3
>    Affects Versions: HADOOP-13345
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: HADOOP-14749-HADOOP-13345-001.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pre-merge cleanup while it's still easy to do
> * Read through all the docs, tune
> * Diff the trunk/branch files to see if we can reduce the delta (and hence the changes)
> * Review the new tests



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message